Avoid some inference in no-name-from-module
#9428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
primer
Skip news π
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9428 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 173 173
Lines 18776 18778 +2
=======================================
+ Hits 17989 17991 +2
Misses 787 787
|
Contributor
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit b8f2efa |
DanielNoord
approved these changes
Feb 11, 2024
Pierre-Sassoulas
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The primer messages for sentry are pretty noisy, which is usually a symptom of some headache in the inference cache. They all seem to be in
no-name-from-module. I couldn't reproduce locally, but I'm hoping avoiding some unnecessary inference here will help.See #9419 (comment)