Skip to content

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Feb 10, 2024

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

If five days elapse without a commit on main, the artifacts created by the last primer / main job are still around, and can be used by the compare job, but the compare job will fail because the venv it needs will likely have been evicted in the meantime because we cache so much and are constantly running low on space.

The solve here is to just let the compare job recreate the venv. I tested by rerunning the primer / main job, and without even waiting for it to finish, I could rerun this failing primer / comment job, and it succeeded.

Refs #9419 (comment)

@jacobtylerwalls jacobtylerwalls added primer Skip news πŸ”‡ This change does not require a changelog entry labels Feb 10, 2024
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing !

@codecov
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (c2294be) 95.80% compared to head (923b4f8) 95.80%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9427   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         173      173           
  Lines       18775    18776    +1     
=======================================
+ Hits        17988    17989    +1     
  Misses        787      787           

see 2 files with indirect coverage changes

@jacobtylerwalls jacobtylerwalls merged commit 659a32f into main Feb 10, 2024
@jacobtylerwalls jacobtylerwalls deleted the primer-comment-venv branch February 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

primer Skip news πŸ”‡ This change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants