Extend exception-related checks to except*
#9197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ntless-statement message on try-clause body
Pierre-Sassoulas
added
False Negative π¦
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
I have a nit but this is going straight into 3.1.0, great work :)
Co-authored-by: Pierre Sassoulas <[email protected]>
Contributor
Author
|
thank you! and thanks for the suggested change, I wasn't aware of that syntax and it looks so much better with less repeated code :-) |
jacobtylerwalls
changed the title
except*
This comment has been minimized.
This comment has been minimized.
β¦ble to specify only testing try* for Python 3.11 and higher
β¦ess testing failures
β¦5/pylint into issue8827_exceptstar
Pierre-Sassoulas
previously approved these changes
Nov 9, 2023
This comment has been minimized.
This comment has been minimized.
auto-merge was automatically disabled
November 10, 2023 02:47
Head branch was pushed to by a user without write access
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9197 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 173 173
Lines 18718 18720 +2
=======================================
+ Hits 17931 17933 +2
Misses 787 787
|
Contributor
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 400c41d |
Pierre-Sassoulas
approved these changes
Nov 10, 2023
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Thank you for your contribution, congrats on becoming a pylint contributor π
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Modify exceptions.py checks to detect
try-except*blocks and treat the same astry-except.Also updated basic_checker.py so that
try-except*blocks are not flagged as "pointless-statement"Functional tests for
broad-exception-caughtandbroad-exception-raisedwere updated to includetry-except*. All tests passed locally withpytest,tox, andprimer.Closes #8827