Skip to content

Fix isinstance-second-argument-not-valid-type for union types with None #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix isinstance-second-argument-not-valid-type for union types with None #8549

merged 1 commit into from
Apr 7, 2023

Conversation

Rogdham
Copy link
Contributor

@Rogdham Rogdham commented Apr 7, 2023

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Fix false positive for isinstance-second-argument-not-valid-type when union type includes None, for example:

isinstance(0, int | None)

Closes #8424

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #8549 (a7f3fba) into main (cb255ea) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8549   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files         174      174           
  Lines       18366    18366           
=======================================
  Hits        17615    17615           
  Misses        751      751
Impacted Files Coverage Ξ”
pylint/checkers/typecheck.py 96.45% <100.00%> (ΓΈ)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit a7f3fba

DanielNoord
DanielNoord approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For clean PR!

@DanielNoord DanielNoord added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/3.3.x labels Apr 7, 2023
@DanielNoord DanielNoord added this to the 2.17.3 milestone Apr 7, 2023
@DanielNoord DanielNoord merged commit b5f2b01 into pylint-dev:main Apr 7, 2023
@github-actions github-actions bot mentioned this pull request Apr 7, 2023
Merged
@Rogdham Rogdham deleted the fix-8424 branch April 8, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.17.3
Development

Successfully merging this pull request may close these issues.

isinstance-second-argument-not-valid-type false positive for union types with None
3 participants
@Rogdham @DanielNoord @Pierre-Sassoulas