[literal-comparison] Make the message more explicit with the solution #7354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2926099913
💛 - Coveralls |
Pierre-Sassoulas
force-pushed
the
more-explicit-message-for-literral-comparison
branch
from
c4dd1da to
fbda020
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit fbda020 |
3 tasks
DanielNoord
reviewed
Aug 25, 2022
|
|
||
| CONST = 24 | ||
|
|
||
| if CONST is 0: # [literal-comparison] |
There was a problem hiding this comment.
Why did you remove these?
There was a problem hiding this comment.
It's duplicated from the literal comparison functional tests.
DanielNoord
approved these changes
Aug 25, 2022
Pierre-Sassoulas
deleted the
more-explicit-message-for-literral-comparison
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Also update the confidence
Closes #5237