Add compare-to-empty-string example

[harupy]

Type of Changes

	Type
✓	📜 Docs

Description

Refs #5953

[Pierre-Sassoulas]

I did not remember we had this check. This is very, very similar to use-implicit-booleaness-not-x type check, it kinda make me want to rename this or move them all in their own checker to make it coherent. Do you have an opinion on this @harupy ?

[harupy]

@Pierre-Sassoulas

move them all in their own checker to make it coherent.

Sounds good to me :)

[Pierre-Sassoulas]

Ok, I took a closer look. compare-to-zero and compare-to-empty-stringare quite more opinionated than use-implicit-booleaness-not-len and use-implicit-booleaness-not-copmparison which is probably why they are in their own optional checker.

Doing x != 0 or feel a lot safer and easier to understand than bool(x) for int (you need a background in C to understand that). Renaming them could be an option, I'm going to open an issue to discuss it but in the meantime I think we could merge this.

[Pierre-Sassoulas]

Created #6871 if you want to chime in :)