Skip to content

Conversation

mbyrnepr2
Copy link
Member

Type of Changes

Type
πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Part of #5953

@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review May 16, 2022 21:42
@matusvalo
Copy link
Collaborator

I think that example will be better, when the default value of get() is used. In this way, the purpose of error is more clear to the reader.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions based on @matusvalo review

@mbyrnepr2
Copy link
Member Author

Thanks @matusvalo & @Pierre-Sassoulas. I agree with your comments.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4405e13 into pylint-dev:main May 17, 2022
@mbyrnepr2 mbyrnepr2 deleted the consider-using-get branch May 17, 2022 09:08
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants