Remove pointless check_messages decorators
#6353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2177892943
💛 - Coveralls |
DanielNoord
reviewed
Apr 16, 2022
| self.add_message("isinstance-second-argument-not-valid-type", node=node) | ||
|
|
||
| # pylint: disable=too-many-branches,too-many-locals | ||
| @check_messages(*(list(MSGS.keys()))) |
DanielNoord
reviewed
Apr 16, 2022
| break | ||
|
|
||
| @check_messages("unsupported-binary-operation") | ||
| def _visit_binop(self, node: nodes.BinOp) -> None: |
Collaborator
There was a problem hiding this comment.
Do you understand why these are underscored? They don't seem to be called in this file..
Collaborator
Author
There was a problem hiding this comment.
I saw that the functional test for this message (unsupported-binary-operation) is always skipped, with the following comment:
Disable for unsupported-binary-operation
Unfortunately, this warning exhibits currently way too many false
positives, practically rendering this error useless. I can't fix
all of them until I release Pylint 1.5, so the most reasonable
choice for now is to disable it and reenable it as soon as we fix
those problems.
Collaborator
There was a problem hiding this comment.
Oh wow, we should probably follow up on that..
But then the decorator is "correct" we only need to de-underscore this function right? Perhaps we should keep the decorator and add a TODO to fix this?
Collaborator
Author
There was a problem hiding this comment.
You are right - if we plan to re-enable this check, the decorator should stay. Will fix this and add a TODO.
Pierre-Sassoulas
added
performance
Maintenance
Pierre-Sassoulas
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
As discussed in #6060,
@check_messageshas no effect in the following cases:visit_*orleave_*: https://github.com/PyCQA/pylint/blob/ebf7bd6793dc484513455d0c47acd6a285a8d1a5/pylint/utils/ast_walker.py#L35-L46)@check_messages(*MSGS). This has the same effect as not decorating it at all:https://github.com/PyCQA/pylint/blob/ebf7bd6793dc484513455d0c47acd6a285a8d1a5/pylint/utils/ast_walker.py#L20-L23
If none of the checker's messages is enabled, we won't load it anyway:
https://github.com/PyCQA/pylint/blob/ebf7bd6793dc484513455d0c47acd6a285a8d1a5/pylint/lint/pylinter.py#L987-L997