Skip to content

Conversation

matusvalo
Copy link
Collaborator

@matusvalo matusvalo commented Apr 8, 2022

Type of Changes

Type
πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Refs #5953

@matusvalo
Copy link
Collaborator Author

isort pre-commit hook "fixed" bad.py file causing it is not showing bad case anymore :-(

@Pierre-Sassoulas
Copy link
Member

isort pre-commit hook "fixed" bad.py file causing it is not showing bad case anymore :-(

Right now you can do something similar to what was done for "reimported": https://github.com/PyCQA/pylint/blob/main/.pre-commit-config.yaml#L40. If it become too much we might exclude all the bad.py from autofixing.

@Pierre-Sassoulas Pierre-Sassoulas merged commit dd54023 into pylint-dev:main Apr 9, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2140972664

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.895%

Totals Coverage Status
Change from base Build 2140969961: 0.0%
Covered Lines: 15888
Relevant Lines: 16921

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants