Examples for bad-exception-context

[DudeNr33]

Co-authored-by: Vladyslav Krylasov [email protected]

• Write a good description on what the PR does.
• If you used multiple emails or multiple names when contributing, add your mails
  and preferred name in script/.contributors_aliases.json

Type of Changes

	Type
	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
✓	📜 Docs

Description

Examples and related links for bad-exception-context.

Ref: #5953

[Pierre-Sassoulas]

Nitpick to not use an Exception in the re-raise feel free to ignore.

[Pierre-Sassoulas]

Suggested change

	def divide(x, y):
	result = 0
	try:
	result = x / y
	except ZeroDivisionError:
	raise ValueError(f"Division by zero when dividing {x} by {y} !") from result # [bad-exception-context]
	return result
	class YParameterIsZero(ZeroDivisionError):
	...
	def divide(x, y):
	result = 0
	try:
	result = x / y
	except ZeroDivisionError:
	raise YParameterIsZero(f"Division by zero when dividing {x} by {y} !") from result # [bad-exception-context]
	return result

[Pierre-Sassoulas]

Suggested change

	def divide(x, y):
	result = 0
	try:
	result = x / y
	except ZeroDivisionError as exc:
	raise ValueError(f"Division by zero when dividing {x} by {y} !") from exc
	return result
	class YParameterIsZero(ZeroDivisionError):
	...
	def divide(x, y):
	result = 0
	try:
	result = x / y
	except ZeroDivisionError as exc:
	raise YParameterIsZero(f"Division by zero when dividing {x} by {y} !") from exc
	return result

[Pierre-Sassoulas]

Nevermind the suggestion it's not that important :)

[DanielNoord]

Oops, sorry guys! Little too trigger happy 😅

[DudeNr33]

😀 No problem, while I think Pierre's last suggestion would have been the best solution, I guess it should be already good enough for the sake of documentation.