Added example for bad-except-order #5997
Conversation
Co-authored-by: Vladyslav Krylasov <[email protected]>
matusvalo
force-pushed
the
bad-except-order
branch
from
5999cba to
ca50f70
Compare
Pull Request Test Coverage Report for Build 2047857185
💛 - Coveralls |
| except Exception: | ||
| raise |
There was a problem hiding this comment.
This would emit try-except-raise, I think, so maybe we should model doing something with the exception?
There was a problem hiding this comment.
Based on this discussion #5992 (comment) we should prefer simplicity/readability over code cleanness.
There was a problem hiding this comment.
That's fair, but I think a flexible approach to this is worth considering, because I suspect we'll get an issue someday "I rewrote my code the way pylint said to but then I got another error".
There was a problem hiding this comment.
I leave the decision to @Pierre-Sassoulas and @DanielNoord
There was a problem hiding this comment.
How about a pass instead of a raise ? Still simple, but no try-except-raise ?
There was a problem hiding this comment.
I guess it's a losing battle because bare-exception is also in play (probably?). So I'm willing to leave this be 😄
5 participants
Type of Changes
Description
Closes partially #5953