-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[invalid-name] Fix FP for exclusive assignment of objects #10746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[invalid-name] Fix FP for exclusive assignment of objects #10746
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10746 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 176 176
Lines 19540 19541 +1
=======================================
+ Hits 18755 18756 +1
Misses 785 785
π New features to boost your workflow:
|
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but seeing the number of new messages being raised I'm not sure we should backport to 4.0.4.
|
Good question. I guess my frame is that we've done these dribbles of fixes to invalid-name to get it stable again, and by merging it we're just unblocking people who are waiting to upgrade to 4. If we wait till 4.1 to fix this, we're just leaving the 4.0 documentation incoherent. ("Use exclusive assignment instead. [It works only half the time.]") |
Type of Changes
Description
Closes #10745