-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Try new branch of astroid
to see if change works
#10152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f9a3b3
to
253ea65
Compare
@jacobtylerwalls Can you test pylint-dev/astroid#2665? At least the |
f23d897
to
4943ebc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10152 +/- ##
==========================================
- Coverage 95.81% 95.80% -0.01%
==========================================
Files 174 174
Lines 18950 18976 +26
==========================================
+ Hits 18156 18180 +24
- Misses 794 796 +2 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
@jacobtylerwalls Primer seems very positive? Or am I misreading it? I'll clear the Action caches and rerun everything, but I'm hopeful my last changes actually work. |
4943ebc
to
dd0fd9c
Compare
astroid
astroid
to see if change works
Thanks @DanielNoord ! |
Try pylint-dev/astroid#2665 and see if it works.
It seemingly does?
I have removed one test that was added in 255562a. I don't really see why it is needed (it clearly isn't a move, but a new test...). With the change for
collections.abc
it should now be_collections_abc
. Anyway,xml.etree.
seems to do the same?