Add .pre-commit-config.yaml
#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Pierre-Sassoulas here is the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 86.50% 87.00% +0.50%
==========================================
Files 33 33
Lines 400 400
Branches 81 81
==========================================
+ Hits 346 348 +2
+ Misses 50 48 -2
Partials 4 4
☔ View full report in Codecov by Sentry. |
Pierre-Sassoulas
approved these changes
Oct 14, 2023
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
So much work done here 😄 ! Enabling more linters can wait for later imo
stdedos
commented
Oct 14, 2023
Member
My bad I thougth it was a mistake in a changelog 😅 |
anis-campos
reviewed
Oct 14, 2023
stdedos
force-pushed
the
ci/pre-commit/config
branch
from
988ff6c to
328eb0b
Compare
Store all tools' configurations in `pyproject.toml`, even if right now only the `setup.py` file is used. Keep `.pylintrc` separately. It is 300 lines; default `--generate-toml-config` gives 600 😅 Comment-out hooks that need >0 work to be green. Signed-off-by: Stavros Ntentos <[email protected]>
Signed-off-by: Stavros Ntentos <[email protected]>
Signed-off-by: Stavros Ntentos <[email protected]>
stdedos
force-pushed
the
ci/pre-commit/config
branch
from
328eb0b to
ff18b58
Compare
Pierre-Sassoulas
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store all tools' configurations in
pyproject.toml,even if right now only the
setup.pyfile is used.Keep
.pylintrcseparately.It is 300 lines; default
--generate-toml-configgives 600 😅Comment-out hooks that need >0 work to be green.
Signed-off-by: Stavros Ntentos [email protected]
Enable https://github.com/asottile/pyupgrade +
.git-blame-ignore-revsSigned-off-by: Stavros Ntentos [email protected]