[fix] Fix parsing deeply nested parentheses causes MemoryError #2809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Look great thank you. But we should probably do something more before reaching the memory error to consider the issue fixed.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 91 91
Lines 11094 11094
=======================================
Hits 10352 10352
Misses 742 742
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
Pierre-Sassoulas
approved these changes
Aug 28, 2025
Member
|
Co-authored-by: Patcher [email protected] ? |
Member
|
Should I keep this in the commit @Synrom ? (Look like a misconfigured git locally) |
Synrom
force-pushed
the
2643-MemoryError-when-parsing-deeply-nested-parentheses
branch
from
8ad7cdf to
cf2227a
Compare
Contributor
Author
|
Sorry, I missed that. Fixed it now. Thanks for catching it! π |
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #2643