Port over some SDL functions to SDL3 #3434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MightyJosip
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of functions that used to return 0 on success, negative error code on failure that in SDL3 return true on success and false on failure. This means our old code compiles but fails at runtime. This PR ports a few of them.
This PR introduces little PG_ compat macros for SDL_SetPaletteColors, SDL_SetSurfaceBlendMode, SDL_GetSurfaceBlendMode, SDL_GetSurfaceAlphaMod, SDL_SetSurfaceAlphaMod.
I only replaced instances of these functions that are actually error checked, I didn't replace them globally. I also fixed a typo in an error message in surf_set_palette.