Requirements for Pyfa #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caught most of the main ones, I think. (Yes I'm sneaking EVE-Gnosis in here, just so I don't have a conflict when I submit the cap/shield sim fix)
Updated Gnosis to point to at least the current version. Pinned Requests as there's a bug in the most recent version. (Only applies to Python 3, but....)
|
Oh nice. I'd dig something like this too! |
|
This will be tied in when #812 gets merged |
|
This should be able to be merged before 812 because we don't reference the (At least, in a normal build scenario. For Pyfa's weird build this may not hold true.) |
|
@blitzmann removed EVE-Gnosis as that's going to have to have other PRs merged, so not quite as quick as I'd hoped.... |
|
What is requirements_test? |
Basically if you are running tests against it outside of an IDE that will handle it for you (like pyCharm). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught most of the main ones, I think.
(Yes I'm sneaking EVE-Gnosis in here, just so I don't have a conflict when I submit the cap/shield sim fix)