Skip to content

Conversation

@jmsmkn
Copy link
Contributor

@jmsmkn jmsmkn commented Feb 17, 2023

Currently pylibjpeg-openjpeg will not build under Python 3.11 due to some changes that were fixed in Cython 0.29.25 (cython/cython#4428). This PR upgrades cython, regenerating _openjpeg.c directly from _openjpeg.pyx. The dependencies on numpy are also updated as 3.11 support was not added there until 1.23.2.

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good! I guess you already did test the packages locally?

@jmsmkn
Copy link
Contributor Author

jmsmkn commented Feb 19, 2023

Thanks, that looks good! I guess you already did test the packages locally?

Beyond the GitHub Actions CI I have built pylibjpeg_openjpeg-1.3.1-cp311-cp311-linux_x86_64.whl locally using Python 3.11.2 and ran our tests that decode some HTJ2K frames using openjpeg.decode, no changes from v1.3.1.

@mrbean-bremen mrbean-bremen merged commit 1abe107 into pydicom:master Feb 19, 2023
@mrbean-bremen
Copy link
Member

Thank you!

@mrbean-bremen
Copy link
Member

Hm, after merging building wheels for Python 3.11 failed in the release workflow...

@jmsmkn
Copy link
Contributor Author

jmsmkn commented Feb 19, 2023

Hm, after merging building wheels for Python 3.11 failed in the release workflow...

Sorry about that, I think I have the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants