Fix numpy 2.1 strings #9536
Closed
Fix numpy 2.1 strings #9536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure this is great, but it does seem to work?
5 tasks
keewis
reviewed
Sep 23, 2024
Comment on lines
+324
to
+332
| not isinstance(data, np.ndarray) | ||
| and ( | ||
| hasattr(data, "__array_function__") or hasattr(data, "__array_namespace__") | ||
| ) | ||
| # Not exactly sure why this is a special case but | ||
| # https://github.com/pydata/xarray/issues/9535 | ||
| # (possibly numpy strings can be | ||
| # indexed but it's indexing the string rather than as an array?) | ||
| and not isinstance(data, np.str_) |
Collaborator
There was a problem hiding this comment.
as pointed out in #9535 I believe this will be resolved by #9403, but in case it doesn't, can we combine the isinstance checks?
Suggested change
| not isinstance(data, np.ndarray) | |
| and ( | |
| hasattr(data, "__array_function__") or hasattr(data, "__array_namespace__") | |
| ) | |
| # Not exactly sure why this is a special case but | |
| # https://github.com/pydata/xarray/issues/9535 | |
| # (possibly numpy strings can be | |
| # indexed but it's indexing the string rather than as an array?) | |
| and not isinstance(data, np.str_) | |
| # Not exactly sure why this is a special case but | |
| # https://github.com/pydata/xarray/issues/9535 | |
| # (possibly numpy strings can be | |
| # indexed but it's indexing the string rather than as an array?) | |
| not isinstance(data, np.ndarray | np.str_) | |
| and ( | |
| hasattr(data, "__array_function__") or hasattr(data, "__array_namespace__") | |
| ) |
2 tasks
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is great, but it does seem to work?