Skip to content

Conversation

@max-sixty
Copy link
Collaborator

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

This auto-fixes problems, so the bar to add it on is low...

Copy link
Contributor

@Illviljan Illviljan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I haven't tried this locally but does it slow down the local runs noticeably? Might be annoying for those who do local pre-commits in that case. But it fits great for the CI and since the bot will autocorrect now I think it outweighs the cons.
One can always turn off the local pre-commit and rely on the CI instead if it becomes to annoying.

@keewis
Copy link
Collaborator

keewis commented Jan 19, 2022

Might be annoying for those who do local pre-commits in that case.

We might need to merge the part of #6024 that deactivates mypy in default pre-commit runs and add a new CI job instead...

@max-sixty max-sixty merged commit 176c6eb into pydata:main Jan 19, 2022
@max-sixty max-sixty deleted the pyupgrade branch January 19, 2022 20:39
@max-sixty
Copy link
Collaborator Author

does it slow down the local runs noticeably?

These ones are fast! mypy is the laggard...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants