Skip to content

Sort backends #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 12, 2021
Merged

Sort backends #4886

merged 7 commits into from
Feb 12, 2021

Conversation

aurghs
Copy link
Collaborator

@aurghs aurghs commented Feb 11, 2021

Ensure that backend list are always sorted in the same way. In particular:

  • the standards backend are always the first in the following order: "netcdf4", "h5netcdf", "scipy"
  • all the other backends a sorted in lexicographic order.

the changes involve two files (plugins.py and test_plugins.py) and they include:

  • add utility function for sorting backends sort_backends

  • Update tests

  • Small changes in variables/functions names.

  • Tests added

  • Passes pre-commit run --all-files

@aurghs aurghs requested a review from alexamici February 11, 2021 04:53
alexamici
alexamici approved these changes Feb 11, 2021
View reviewed changes
@alexamici alexamici merged commit 6e4d667 into pydata:master Feb 12, 2021
dcherian added a commit to dcherian/xarray that referenced this pull request Feb 17, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into dataset/quiver
2b1bc32 
* upstream/master:
  FIX: h5py>=3 string decoding (pydata#4893)
  Update matplotlib's canonical (pydata#4919)
  Adding vectorized indexing docs (pydata#4711)
  Allow fsspec URLs in open_(mf)dataset (pydata#4823)
  Fix typos in example notebooks (pydata#4908)
  pre-commit autoupdate CI (pydata#4906)
  replace the ci-trigger action with a external one (pydata#4905)
  Update area_weighted_temperature.ipynb (pydata#4903)
  hide the decorator from the test traceback (pydata#4900)
  Sort backends (pydata#4886)
  Compatibility with dask 2021.02.0 (pydata#4884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexamici alexamici alexamici approved these changes

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
grant-czi topic-backends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aurghs @alexamici @andersy005