Skip to content

Bump mypy to v0.761 #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Bump mypy to v0.761 #3704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repos:
hooks:
- id: flake8
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.730 # Must match ci/requirements/*.yml
rev: v0.761 # Must match ci/requirements/*.yml
hooks:
- id: mypy
# run these occasionally, ref discussion https://github.com/pydata/xarray/pull/3194
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/py36-min-all-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies:
- iris=2.2
- lxml=4.4 # Optional dep of pydap
- matplotlib=3.1
- mypy=0.730 # Must match .pre-commit-config.yaml
- mypy=0.761 # Must match .pre-commit-config.yaml
- nc-time-axis=1.2
- netcdf4=1.4
- numba=0.44
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/py36.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
- iris
- lxml # optional dep of pydap
- matplotlib
- mypy=0.730 # Must match .pre-commit-config.yaml
- mypy=0.761 # Must match .pre-commit-config.yaml
- nc-time-axis
- netcdf4
- numba
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/py37-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
- iris
- lxml # Optional dep of pydap
- matplotlib
- mypy=0.730 # Must match .pre-commit-config.yaml
- mypy=0.761 # Must match .pre-commit-config.yaml
- nc-time-axis
- netcdf4
- numba
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/py37.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
- iris
- lxml # Optional dep of pydap
- matplotlib
- mypy=0.730 # Must match .pre-commit-config.yaml
- mypy=0.761 # Must match .pre-commit-config.yaml
- nc-time-axis
- netcdf4
- numba
Expand Down
2 changes: 1 addition & 1 deletion xarray/core/computation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def _as_variables_or_variable(arg):
def _unpack_dict_tuples(
result_vars: Mapping[Hashable, Tuple[Variable, ...]], num_outputs: int
) -> Tuple[Dict[Hashable, Variable], ...]:
out = tuple({} for _ in range(num_outputs)) # type: ignore
out: Tuple[Dict[Hashable, Variable], ...] = tuple({} for _ in range(num_outputs))
for name, values in result_vars.items():
for value, results_dict in zip(values, out):
results_dict[name] = value
Expand Down
6 changes: 3 additions & 3 deletions xarray/core/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,11 +897,11 @@ def _replace(
if dims is not None:
self._dims = dims
if attrs is not _default:
self._attrs = attrs # type: ignore # FIXME need mypy 0.750
self._attrs = attrs
if indexes is not _default:
self._indexes = indexes # type: ignore # FIXME need mypy 0.750
self._indexes = indexes
if encoding is not _default:
self._encoding = encoding # type: ignore # FIXME need mypy 0.750
self._encoding = encoding
obj = self
else:
if variables is None:
Expand Down