Skip to content

Match mypy version between CI and pre-commit hook #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Match mypy version between CI and pre-commit hook #3203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repos:
hooks:
- id: flake8
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.720
rev: v0.720 # Must match ci/requirements/*.yml
hooks:
- id: mypy
# run these occasionally, ref discussion https://github.com/pydata/xarray/pull/3194
Expand Down
4 changes: 2 additions & 2 deletions ci/requirements/py36.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ dependencies:
- pytest-env
- coveralls
- flake8
- mypy==0.720 # Must match .pre-commit-config.yaml
- numpy>=1.12
- pandas>=0.19
- pip
Expand All @@ -34,5 +35,4 @@ dependencies:
- iris>=1.10
- pydap
- lxml
- pip:
- mypy==0.711

2 changes: 1 addition & 1 deletion ci/requirements/py37.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies:
- pytest-env
- coveralls
- flake8
- mypy==0.720 # Must match .pre-commit-config.yaml
- numpy>=1.12
- pandas>=0.19
- pip
Expand All @@ -32,5 +33,4 @@ dependencies:
- lxml
- pydap
- pip:
- mypy==0.650
- numbagg
3 changes: 2 additions & 1 deletion xarray/core/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,8 @@ def __init__(
self._indexes = None # type: Optional[OrderedDict[Any, pd.Index]]

if attrs is not None:
self.attrs = attrs
self._attrs = OrderedDict(attrs)

self._encoding = None # type: Optional[Dict]
self._initialized = True

Expand Down