Testing deprecations #1825
Closed
Testing deprecations #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Jan 13, 2018
| matplotlib = pytest.importorskip('matplotlib', minversion='1.9.0') | ||
| """ |
There was a problem hiding this comment.
I don't this can work until pytest-dev/pytest#568 is fixed.
max-sixty
force-pushed
the
testing-deprecations
branch
from
e15f777 to
252f7a6
Compare
|
Closing in favor of #1828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re comment here: #1640 (comment)
The
TestCasefunctions I think we should deprecate_importorskipI'm less sure about - there are some reasons to keep them if we need flexibility in the future (and it doesn't matter much)