Skip to content

Use numpy's normalize_axis_index, if available #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use numpy's normalize_axis_index, if available #1679

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link

Curious if you think this is a good idea

@shoyer
Copy link
Member

shoyer commented Nov 1, 2017

Yes, this looks like a good idea. Though I'd prefer if the logic were in core/npcompat.py instead, which is where the rest of our NumPy backports are.

@max-sixty
Copy link
Collaborator

@eric-wieser any interest in moving this to npcompat.py?

@dcherian dcherian mentioned this pull request Jan 21, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-wieser @shoyer @max-sixty