Fix setuptools deprecation warnings #10300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gcaria
commented
May 9, 2025
gcaria
commented
- Closes setuptools deprecation warnings #10191
max-sixty
reviewed
May 9, 2025
Collaborator
max-sixty
left a comment
max-sixty
left a comment
There was a problem hiding this comment.
top stuff is great (can merge that now if you prefer), I think we can be more standard for the setuptools work
pyproject.toml
Outdated
| include-package-data = false | ||
|
|
||
| [tool.setuptools.package-data] | ||
| "*" = ["*.py"] |
Collaborator
There was a problem hiding this comment.
I think we need something like this:
[tool.setuptools.packages.find]
include = ["xarray*"]
...since that change will preclude *.pyi files...
Contributor
Author
There was a problem hiding this comment.
ah yes! I had definitely misinterpreted the original issue
Collaborator
|
thanks @gcaria ! |
Collaborator
|
(feel free to add whatsnew entries for these in a separate PR!) |
Contributor
|
Thanks @gcaria! @max-sixty's above suggestion is still valid. |
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.