Skip to content

Handle new data model in pydap v3.5.5+ #10226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Handle new data model in pydap v3.5.5+ #10226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e0e38
handle new data model in pydap v3.5.5+
Zeitsperre Apr 14, 2025
300ad12
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion xarray/backends/pydap_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,11 @@ def open(

def open_store_variable(self, var):
data = indexing.LazilyIndexedArray(PydapArrayWrapper(var))
return Variable(var.dimensions, data, _fix_attributes(var.attributes))
return Variable(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mikejmnez does this look right to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Zeitsperre ! Thanks for pointing me to this @dcherian .

Please see this #10182 , which is ready for review ;)

I have made some change on the pydap end of things (e.g. dims and dimensions). The documentation is not yet updated there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mikejmnez, this change was working for my use-case, but it looks like the real fix is ever-so-slightly more complicated than my patch here ;). Closing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems, and thanks a lot @Zeitsperre for the attempted fix :) . Indeed that would have gotten rid of the slashes on dim names +1

var.dimensions if hasattr(var, "dimensions") else var.dims,
data,
_fix_attributes(var.attributes),
)

def get_variables(self):
return FrozenDict(
Expand Down
Loading