remove outdated type-ignores #10006
Merged
remove outdated type-ignores #10006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
Those typing issues are a real pain. So the typing worked in an environment with numpy 2.0.2. It failed with numpy 2.1.3. When removing that type-ignore it resurfaces for numpy dev version. Weird.
xarray/core/dataset.py:9144: error: Unused "type: ignore" comment [unused-ignore]
xarray/core/dataset.py: note: In member "polyfit" of class "Dataset":
xarray/core/dataset.py:9144: error: Incompatible types in assignment (expression has type "floating[Any]", variable has type "float | None") [assignment] |
Contributor
Author
|
So the floating Any issue is probably this: python/mypy#18566. Good to merge? |
3 tasks
max-sixty
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rst