Fix color regression in sphinx_design and sphinx_panels #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--pst-color-background-up` was not defined. Replacing with `--pst-color-on-background`
12rambau
approved these changes
Jun 13, 2022
Collaborator
12rambau
left a comment
12rambau
left a comment
There was a problem hiding this comment.
Nice catch! I think these 2 PR were merged more or less at the same time and I forgot to use the new variables in the scss. Thanks for the PR
Collaborator
|
Could you reproduce your modifications in the |
Contributor
Author
|
@12rambau. Of course, but I thought I already did that. Let me know if there is anything else needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix color regression in sphinx_design and sphinx_panels from #659
I pointed the following variables to the new versions. @12rambau, please check that it makes sense:
--pst-color-preformatted-border->--pst-color-border--pst-color-active-navigation->--pst-color-primary--pst-color-deactive-navigation->--pst-color-text-mutedfixes: #727
This PR also fixes that
--pst-color-background-upwas not defined.Replacing with
--pst-color-on-background