Warning admonition shows red instead of yellow

[kylekeppler]

On the demo site, a warning admonition is yellow. On my docs it shows red. I have v 0.4.3 from conda-forge installed and sphinx 3.5 installed.

Not sure where else to look or what additional information would be helpful.

[12rambau]

to go further I think that the admonition coloring in general could be improved:

I printed here all the admonition that I know :

Admonition Example
------------------

.. seealso::
   
   see also 

.. note::

    a note 

.. tip::

    a tip 

.. important::

    a inportant information 

.. warning::

    a warning 

.. attention::

    an attention 

.. danger::

    a danger 

and get the following result

based on what I know of rst and bootstrap :

• seealso: primary
• note: info
• tip: warning
• important: info
• warning: danger
• attention: a custom orange
• danger: danger

I think it could be nice to have instead the following color repartition:

• seealso: primary
• note: info
• tip: warning
• important: success (with another icon like far fa-star)
• warning: a custom orange
• attention: a custom orange
• danger: danger

I would be happy to make a PR but I don't know where to start

[jorisvandenbossche]

@kylekeppler sorry for the slow answer; this has recently changed on master, see #281, but this is not yet included in the release. I suppose you were looking at the demo site using the latest master version.

@12rambau thaks for thinking about how this can be improved! Can you first take a look at #281 and try with latest master? As we already changed some things there (and there is also some discussion about the colors in that PR and the linked issue)

[12rambau]

Thanks I just had a look at the colors and icons inside https://github.com/pydata/pydata-sphinx-theme/blob/master/pydata_sphinx_theme/static/css/theme.css and they seems perfect to me.

I was so close from a PR but you were faster :-)

I'll wait for the release

[kylekeppler]

Thanks for the update @jorisvandenbossche. I'd love to see an update pushed!

[timhoffm]

Looking at https://pydata-sphinx-theme.readthedocs.io/en/latest/demo/demo.html#admonitions
colors seem correct now. So I think the issue can be closed.