MNT: use compat functions for accessing dtype state #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ok, your PR does not compile yet. I think there should be no problem in vendoring |
Contributor
|
Overridden by #478 |
Author
|
🎉 Thank you! I did not have time to come back and finish this and it looks like @neutrinoceros did a better job than I would have anyway! |
Contributor
|
Oh my, I absolutely didn't realize I was scoping your PR, sorry I didn't look hard enough ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complies with the numpy main branch, but did not test with older versions of numpy (I suspect it wont work due to missing functions)
The
np_2_compat.his designed to be vendored down stream, I think the question is if numexpr wants the whole thing or just the minimal sub-set needed to fix these problems.