Skip to content

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 30, 2023

Change Summary

Updates to the new PyO3 0.19.2 release.

Related issue number

Closes #659

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #844 (5cbdd8d) into main (d15d039) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   93.51%   93.52%           
=======================================
  Files         102      102           
  Lines       14609    14609           
  Branches       25       25           
=======================================
+ Hits        13662    13663    +1     
+ Misses        941      940    -1     
  Partials        6        6           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15d039...5cbdd8d. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 30, 2023

CodSpeed Performance Report

Merging #844 will degrade performances by 47.25%

Comparing dh/pyo3-0.19.2 (5cbdd8d) with main (d15d039)

Summary

🔥 6 improvements
❌ 6 regressions
✅ 123 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/pyo3-0.19.2 Change
test_complete_core_lax 1.1 ms 1.3 ms -16.45%
🔥 test_core_python 498 µs 444.5 µs +12.03%
🔥 test_core_string_lax_wrong 60.1 µs 37.4 µs +60.49%
🔥 test_date_from_datetime_str 29 µs 26.2 µs +10.82%
🔥 test_date_from_datetime 39.3 µs 35.4 µs +11.17%
🔥 test_core_python 46.5 µs 40.6 µs +14.6%
test_dont_raise_error_no_info 22.4 µs 26.4 µs -15.24%
🔥 test_with_default 44.1 µs 36.4 µs +21.14%
test_int_error 73.8 µs 97.5 µs -24.35%
test_tagged_union_int_keys_python 30.3 µs 57.5 µs -47.25%
test_core_model_py 47.4 µs 61.5 µs -22.99%
test_core_model_py_extra 56 µs 67.2 µs -16.72%

@davidhewitt
Copy link
Contributor Author

We saw similar regressions in #842 (comment), did main just have a crazy good build???

@adriangb
Copy link
Member

Looks like it 😞

@davidhewitt davidhewitt marked this pull request as ready for review August 1, 2023 06:36
@samuelcolvin samuelcolvin merged commit ca1055b into main Aug 3, 2023
@samuelcolvin samuelcolvin deleted the dh/pyo3-0.19.2 branch August 3, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with PyPy3.10 7.3.12rc2
3 participants