Skip to content

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 3, 2023

Change Summary

Enable PyPy 3.10 wheels on ubuntu & windows following a merge race between #678 and #731.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@davidhewitt
Copy link
Contributor Author

please review

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #733 (ab06bef) into main (d76812a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   93.63%   93.63%   -0.01%     
==========================================
  Files          99       99              
  Lines       13913    13895      -18     
  Branches       25       25              
==========================================
- Hits        13028    13010      -18     
  Misses        879      879              
  Partials        6        6              
Impacted Files Coverage Δ
src/validators/dataclass.rs 98.31% <ø> (-0.02%) ⬇️
src/validators/generator.rs 91.39% <ø> (-0.07%) ⬇️
src/validators/mod.rs 97.77% <ø> (-0.03%) ⬇️
src/validators/model_fields.rs 98.30% <ø> (-0.01%) ⬇️
src/validators/typed_dict.rs 97.39% <ø> (ø)
python/pydantic_core/core_schema.py 96.64% <100.00%> (+<0.01%) ⬆️
src/validators/function.rs 91.36% <100.00%> (-0.05%) ⬇️
src/validators/model.rs 98.37% <100.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad1425...ab06bef. Read the comment docs.

@adriangb adriangb enabled auto-merge (squash) July 3, 2023 18:38
@adriangb adriangb merged commit 193ec86 into main Jul 3, 2023
@adriangb adriangb deleted the dh/pgo-pypy3.10 branch July 3, 2023 18:39
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2023

CodSpeed Performance Report

Merging #733 will degrade performances by 12.58%

Comparing dh/pgo-pypy3.10 (ab06bef) with main (9ad1425)

Summary

🔥 1 improvements
❌ 2 regressions
✅ 123 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/pgo-pypy3.10 Change
🔥 test_complete_core_json 2.8 ms 2.5 ms +12.03%
test_list_of_ints_core_json 5.2 ms 5.9 ms -11.34%
test_set_of_ints_core_json_duplicates 4.2 ms 4.8 ms -12.58%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants