Add output_json_schema method to Agent class #3454
Conversation
|
@DouweM is there a source of truth I can reference for what the schema output should be for tests? I think I will get stuck figuring this out so any guidance will be appreciated. Edit: I added snapshots of expected output to the tests. Please review them carefully as I'm guessing what they are supposed to be. |
g-eoj
changed the title
| return self.text_processor is not None | ||
|
|
||
| @abstractmethod | ||
| def dump(self) -> JsonSchema: |
There was a problem hiding this comment.
Can we call the method json_schema()?
There was a problem hiding this comment.
If allows_deferred_tools is True, we should add the schema of DeferredToolRequests to the output union
Same for allows_image and BinaryImage.
So we may have to implement that here, and then have the subclass methods call super() and combine that with the union somehow.
| return 'image' | ||
|
|
||
| def dump(self) -> JsonSchema: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
You can use the schema of BinaryImage
| processors.append(processor) | ||
| return UnionOutputProcessor(processors).object_def.json_schema | ||
|
|
||
| return self.processor.object_def.json_schema |
There was a problem hiding this comment.
We don't need the toolset logic; this one should always be present
| processor.object_def.name = tool_def.name | ||
| processor.object_def.description = tool_def.description | ||
| processors.append(processor) | ||
| return UnionOutputProcessor(processors).object_def.json_schema |
There was a problem hiding this comment.
Hmm this is a bit ugly :) Can we add a new json_schema property to OutputToolset, and then generate this inside OutputToolset.build, where we already have the processors etc?
There was a problem hiding this comment.
If self.allows_text is enabled, we should add {type: string} to the union. (similar to what I said above). We may need some logic to take a UnionOutputProcessor and basically add a new branch to it, (instead of ending up with nested unions that could be flattened)
| if isinstance(output, ObjectOutputProcessor): | ||
| processor = output | ||
| else: | ||
| processor = ObjectOutputProcessor(output=output, strict=strict) |
There was a problem hiding this comment.
Why did we need to change this?
2 participants
Closes #3225
Note: there is still some discussion whetheroutput_json_schemashould be a property or method: #3225 (comment)Need help with:
AutoOutputSchemaexpected output schema?ImageOutputSchemaexpected output schema?ToolOutputSchema,toolsetcan beNone... how to handle?