validate OpenAI responses #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
Kludex
reviewed
Jul 17, 2025
Member
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
How are you generating those tests? Manually? 🤔
Member
Author
I generated them by changing the URL to something that returned text from a post request, then setting the URL back. |
Kludex
approved these changes
Jul 21, 2025
DouweM
approved these changes
Jul 21, 2025
KRRT7
pushed a commit
to aseembits93/pydantic-ai
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DouweM @Kludex I think there were some issues about this, can you remember?
maybe fixes #527?
Although the OpenAI SDK claims to return a Pydantic model (
ChatCompletion) from the chat completions endpoint:model_constructor something?!)Thus we validate it fully here.