Improve doc comments of filter-pushdown-apis
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/filter_pushdown_suggestions
branch
from
7f0c67d to
07ec42f
Compare
alamb
force-pushed
the
alamb/filter_pushdown_suggestions
branch
from
07ec42f to
308327e
Compare
adriangb
reviewed
Apr 5, 2025
adriangb
reviewed
Apr 5, 2025
| /// Default implementation returns `Ok(None)`. See [`ExecutionPlan::with_filter_pushdown_result`] | ||
| /// for more details. | ||
| /// | ||
| /// [`ExecutionPlan::push_down_filters`]: datafusion_physical_plan::execution_plan::ExecutionPlan::with_filter_pushdown_result |
Member
There was a problem hiding this comment.
Thanks will use this style of reference elswhere
adriangb
reviewed
Apr 5, 2025
adriangb
reviewed
Apr 5, 2025
adriangb
added a commit
that referenced
this pull request
Apr 8, 2025
* Improve doc comments * Apply suggestions from code review --------- Co-authored-by: Adrian Garcia Badaracco <[email protected]>
adriangb
added a commit
that referenced
this pull request
Apr 18, 2025
… them (apache#15566) * ExecutionPlan: add APIs for filter pushdown & optimizer rule to apply them * wip * fix tests * fix * fix * fix doc * fix doc * Improve doc comments of `filter-pushdown-apis` (#22) * Improve doc comments * Apply suggestions from code review --------- Co-authored-by: Adrian Garcia Badaracco <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Lamb <[email protected]> * simplify according to pr feedback * Add missing file * Add tests * pipe config in * docstrings * Update datafusion/physical-plan/src/filter_pushdown.rs * fix * fix * fmt * fix doc * add example usage of config * fix test * convert exec API and optimizer rule * re-add docs * dbg * dbg 2 * avoid clones * part 3 * fix lint * tests pass * Update filter.rs * update projection tests * update slt files * fix * fix references * improve impls and update tests * apply stop logic * update slt's * update other tests * minor * rename modules to match logical optimizer, tweak docs --------- Co-authored-by: Andrew Lamb <[email protected]> Co-authored-by: berkaysynnada <[email protected]> Co-authored-by: Berkay Şahin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing apache#15566 and several suggestions for comments came to my mind. Rather than leaving a bunch of suggestions on the PR I figured I would just make a PR with the suggestions directly