Fix ArrowReaderOptions should read with physical_file_schema so we do… #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't need to cast back to utf8
alamb
reviewed
Apr 4, 2025
| ArrowReaderOptions::new().with_page_index(true), | ||
| ArrowReaderOptions::new() | ||
| .with_page_index(true) | ||
| .with_schema(physical_file_schema.clone()), |
adriangb
added a commit
that referenced
this pull request
Apr 6, 2025
… ParquetOpener (apache#15561) * parquet reader: move pruning predicate creation from ParquetSource to ParquetOpener * use file schema, avoid loading page index if unecessary * Add comment * add comment * Add comment * remove check * fix clippy * update sqllogictest * restore to explain plans * reverted * modify access * Fix ArrowReaderOptions should read with physical_file_schema so we do… (#17) * Fix ArrowReaderOptions should read with physical_file_schema so we don't need to cast back to utf8 * Fix fmt * Update opener.rs * Always apply per-file schema during parquet read (#18) * Update datafusion/datasource-parquet/src/opener.rs --------- Co-authored-by: Qi Zhu <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n't need to cast back to utf8
Which issue does this PR close?
Make the benchmark back to normal.
Rationale for this change
Fix ArrowReaderOptions should read with physical_file_schema
Make the benchmark back to normal.
What changes are included in this PR?
Fix ArrowReaderOptions should read with physical_file_schema
Make the benchmark back to normal.
Are these changes tested?
Yes
Are there any user-facing changes?
No