Add typing annotations #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam_vagrant_command Signed-off-by: Leonard Crestez <[email protected]>
Signed-off-by: Leonard Crestez <[email protected]>
Since python2 is no longer supported maybe this could be removed entirely instead. Signed-off-by: Leonard Crestez <[email protected]>
Raising an explicit exception instead of concatenating with None makes type checkers happy. Signed-off-by: Leonard Crestez <[email protected]>
This is slightly faster and helps type checkers Signed-off-by: Leonard Crestez <[email protected]>
Signed-off-by: Leonard Crestez <[email protected]>
Signed-off-by: Leonard Crestez <[email protected]>
cdleonard
requested review from
apatard,
konstruktoid and
ssbarnea
as code owners
konstruktoid
approved these changes
Nov 12, 2022
Collaborator
|
thanks @cdleonard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds typing annotations to the point that mypy passes with "disallow_untyped_calls=true".