pre-commit: Remove default_language_version python3.8 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not necessary and fails on recent distros. Signed-off-by: Leonard Crestez <[email protected]>
cdleonard
requested review from
apatard,
konstruktoid and
ssbarnea
as code owners
Contributor
Author
|
Maybe this was copy-pasted from somewhere? I don't have python3.8 on ubuntu22 and don't want to dig around dead snakes so I just removed this to get pre-commit checks to pass. |
Contributor
Author
|
Failure is inside "test_multivm_lifecycle" and only for python3.10, it makes no sense. |
Collaborator
something just didnt play along. |
konstruktoid
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not necessary and fails on recent distros.
Signed-off-by: Leonard Crestez [email protected]