Skip to content

Fix streaming with python3+ #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Fix streaming with python3+ #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a55e113
vagrant/__init__.py: don't set bufsize in _stream_vagrant_command
apatard Mar 29, 2022
4c65e0d
test_streaming_output: change test string
apatard Mar 29, 2022
89ba46a
chore: auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_vagrant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ def test_streaming_output(vm_dir):
"""
Test streaming output of up or reload.
"""
test_string = "Waiting for machine to boot."
test_string = "Machine already provisioned"
v = vagrant.Vagrant(vm_dir)

with pytest.raises(subprocess.CalledProcessError):
Expand Down
1 change: 0 additions & 1 deletion vagrant/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,6 @@ def _stream_vagrant_command(self, args):
env=self.env,
stdout=subprocess.PIPE,
stderr=err_fh,
bufsize=1,
)

# Iterate over output lines.
Expand Down