Skip to content

Invoke PipedCompressionProgram directly rather than through subclassing #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Invoke PipedCompressionProgram directly rather than through subclassing #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eba7ed1
Store compression program settings in dedicated objects, rather than …
rhpvorderman Feb 5, 2024
17a95f2
Remove redundant _can_read_concatenated_gz function
rhpvorderman Feb 5, 2024
f7420c0
Make the PROGRAM_SETTINGS dict private
rhpvorderman Feb 5, 2024
a883bfc
Write a changelog entry for the subclass removal
rhpvorderman Feb 5, 2024
3c31757
Use immutable default rather than None for _program_args
rhpvorderman Feb 5, 2024
403ade3
Make _open_gz piped program opening simpler
rhpvorderman Feb 6, 2024
6d0117c
Pass _ProgramSettings class directly rather than using **kwargs
rhpvorderman Feb 9, 2024
765a833
Revert variable name change
rhpvorderman Feb 9, 2024
1be7ad6
Add commentary from lost docstrings in _open functions
rhpvorderman Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,16 @@ Changelog

in-development
~~~~~~~~~~~~~~~~~~~
* #146: PipedCompressionReader/Writer are now binary-only. For text reading
they are wrapped in an ``io.TextIOWrapper`` in the ``xopen()`` function.
* #146, #147, #148: Various refactors for better code size and readability:

* PipedCompressionReader/Writer are now combined _PipedCompressionProgram
class.
* _PipedCompressionProgram is binary-only. For text reading and writing
it is wrapped in an ``io.TextIOWrapper`` in the ``xopen()`` function.
* Classes that derive from PipedCompressionReader/Writer have been removed.
* #148: xopen's classes, variables and functions pertaining to piped reading
and writing are all made private by prefixing them with an underscore.
These are not part of the API and may change between releases.

v1.9.0 (2024-01-31)
~~~~~~~~~~~~~~~~~~~
Expand Down
Loading