This repository was archived by the owner on Sep 16, 2024. It is now read-only.
esp32: Add code for the second parameter of DAC.tone() #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter specifies the level, which is already documented, but was not implemented. Suitable values: 0: Tone level 3.02 Vpp at 560 Ohm load, about 0 dbV 1: Tone level 1.54 Vpp, about -6 dBV 2: Tone level 0.8 Vpp, about -12 dBV 3: Tone level 0.4 Vpp, about -18 dBV Adding a small load is reccomended, since that also suppresses DAC reloading spikes.
|
@robert-hh Thanks |
|
@oligauc What? The comments says: "Closed with unmerged commits" |
|
Hello Robert, Your patch will be available in the next releases. It must undergo regression and unit tests before it makes it to the official repo. |
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
Changes needed for idf 3.3.
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter specifies the level, which is already documented, but was
not implemented. Suitable values:
0: Tone level 3.02 Vpp at 560 Ohm load, about 0 dbV
1: Tone level 1.54 Vpp, about -6 dBV
2: Tone level 0.8 Vpp, about -12 dBV
3: Tone level 0.4 Vpp, about -18 dBV
Adding a small load is reccomended, since that also suppresses
DAC reloading spikes.