-
Notifications
You must be signed in to change notification settings - Fork 82
Pycoproc #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Typo changed comma to dot
* LTE: document CEREG impact on downgrades
…ss ajustments to text
Adding youtube video embedded
Youtube format div-layout
|
I remember we spoke about this the other day in person. Is this now ready for review or WIP? |
|
This is ready for review |
* added android app information * cleared up usage
Adds Montserrat font and adds to CSS, Makes H2 Bebas font and small c…
peter-pycom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I think there are some bigger structural issues. Maybe you want to address them here or in another PR, that's fine. Please let me know.
- How would someone find pycoproc or pycoproc2? It kinda just falls out of the heavens but nobody would ever know to go there. It's not linked from anywhere. I think there should be a logical flow from
- There is nothing that creates a connection from e.g., Pysense to Accelerometer. How do I know which of the sensors a Pyscan has?!
- I think there should be a useful 'landing page' per shield. Can be short, a picture and short summary and a couple of links (sensors, lib, pycoproc)
- There should be a overview page for the sensors where we link the technical driver/API names to human readable names. In the side navigation in the API section we should use the technical names. That would be consistent with the technical pycoproc name
- Step 4 on getting started page should use the "Shield" language instead of "Expansionboard"
A couple smaller items, which I think should be addressed in this PR:
- we said we wouldn't use the term "pyshields", please reformulate
- I know we said that eventually we want to make releases with individual zip files, but that hasn't happened yet and it's a little more complicated than I thought. Still doable, and still the plan, but it has yet to happen. So for the moment it doesn't make sense to link to the releases page. Instead please link to the folder inside the pycom-libraries repository.
- The links in the tutorials & examples section to pycom-libraries subfolder are now broken, e.g. on https://pr-375.d1rmdw1xyxqk1e.amplifyapp.com/tutorials/expansionboards/pysense2/
|
|
|
Thanks for the suggestions. I fixed the ones applicable to the scope of this PR, but we will definitely need to look into the examples and improve the linking there. |
|
Still open:
Closed:
|
No description provided.