Skip to content

Conversation

@mhils
Copy link
Member

@mhils mhils commented May 11, 2022

(depends on cryptography 38)

Follow-up to pyca/cryptography#7210. :)
I've added comments to point out the duplication between Context and Connection. Let me know if you want those out, happy to adjust to whatever style you prefer.

@mhils mhils force-pushed the connection-use-cert branch 3 times, most recently from 2cd7a49 to e05eac4 Compare May 12, 2022 11:39
@mhils mhils marked this pull request as draft May 12, 2022 11:52
@reaperhulk
Copy link
Member

cryptography 38 is out now 😄

@mhils mhils force-pushed the connection-use-cert branch from e05eac4 to d3c13ac Compare September 7, 2022 10:53
@mhils mhils marked this pull request as ready for review September 7, 2022 11:42
@reaperhulk
Copy link
Member

Conflict here due to the new pinning, but we should get this reviewed ASAP 😄

@mhils
Copy link
Member Author

mhils commented Sep 16, 2022

Conflict fixed! 😃

@reaperhulk reaperhulk merged commit f0ed288 into pyca:main Sep 16, 2022
@mhils mhils mentioned this pull request Sep 25, 2022
@mhils mhils deleted the connection-use-cert branch September 25, 2022 16:26
@balloob
Copy link

balloob commented Sep 25, 2022

This PR has not updated the changelog. Changelog for 22.1 still mentions Cryptography 37 as the minimum version.

@reaperhulk
Copy link
Member

@balloob Thanks for the report, we've got a changelog fix up in #1150 although we may also need to spin some knobs on readthedocs as well since this won't fix the stable tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants