-
-
Notifications
You must be signed in to change notification settings - Fork 136
#411 Rename SerialTitle
classes
#412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nils-herrmann
wants to merge
2
commits into
pybliometrics-dev:master
Choose a base branch
from
nils-herrmann:feat/411
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 12 additions & 4 deletions
16
...s/sciencedirect/tests/test_SerialTitle.py → ...iencedirect/tests/test_SerialTitleISSN.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
from collections import OrderedDict | ||
from typing import Optional, Union | ||
import warnings | ||
|
||
from pybliometrics.superclasses import Search | ||
from pybliometrics.utils import check_parameter_value, make_search_summary, VIEWS | ||
|
||
|
||
class SerialSearch(Search): | ||
class SerialTitleSearch(Search): | ||
@property | ||
def results(self) -> Optional[list[OrderedDict[str, str]]]: | ||
"""A list of OrderedDicts representing results of serial search. The | ||
|
@@ -53,7 +54,7 @@ def __init__(self, | |
view: str = 'ENHANCED', | ||
**kwds: str | ||
) -> None: | ||
"""Interaction with the Serial Title API. | ||
"""Interaction with the base endpoint of the `Serial Title API`. | ||
|
||
:param query: Query parameters and corresponding fields. Allowed keys | ||
'title', 'issn', 'pub', 'subj', 'subjCode', 'content', | ||
|
@@ -92,7 +93,7 @@ def __init__(self, | |
invalid = [k for k in query.keys() if k not in allowed_query_keys] | ||
if invalid: | ||
raise ValueError(f'Query key(s) "{", ".join(invalid)}" invalid') | ||
check_parameter_value(view, VIEWS['SerialSearch'], "view") | ||
check_parameter_value(view, VIEWS['SerialTitleSearch'], "view") | ||
|
||
# Query | ||
self._query = str(query) | ||
|
@@ -178,3 +179,16 @@ def _retrieve_source_rankings(source_data): | |
for t in stats: | ||
out.append([f"{key}_['@year']", t['$']]) | ||
return out or None | ||
|
||
|
||
def SerialSearch(*args, **kwds): | ||
"""Deprecated: Use SerialTitleSearch instead. | ||
This class is deprecated and will be removed. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please write: "will be removed with the next major release." |
||
""" | ||
warnings.warn( | ||
"SerialSearch is deprecated and will be removed." | ||
"Use SerialTitleSearch instead.", | ||
DeprecationWarning, | ||
stacklevel=2 | ||
) | ||
return SerialTitleSearch(*args, **kwds) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write: "will be removed with the next major release."