Skip to content

GHA: Test pip install with Mingw64 python and gcc #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2021
Merged

GHA: Test pip install with Mingw64 python and gcc #75

merged 2 commits into from
Aug 5, 2021

Conversation

@jeromerobert
Copy link
Contributor

@jeromerobert jeromerobert commented May 6, 2021

Add a test for pybind/pybind11#2921

@jeromerobert
Copy link
Contributor Author

jeromerobert commented May 6, 2021

This willl fail until pybind/pybind11#2921 reach PyPI, so I tag this PR as draft.

@jeromerobert jeromerobert marked this pull request as draft May 6, 2021 10:02
@jeromerobert jeromerobert marked this pull request as ready for review July 17, 2021 15:15
@jeromerobert
Copy link
Contributor Author

jeromerobert commented Jul 17, 2021

pybind11 2.7.0 is now released, so pybind/pybind11#2921 reach PyPI, so this PR is ready for merge.

@henryiii
Copy link
Collaborator

henryiii commented Jul 17, 2021

Possibly sysconfig tells you what Python was built with, not what you are targeting? (Which probably requires a customization to the build command)?

@jeromerobert
Copy link
Contributor Author

jeromerobert commented Jul 17, 2021

sysconfig.get_platform() is not mingw anymore, so I need to do a new PR in https://github.com/pybind/pybind11 😭. See
https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-python/0099-Change-the-get_platform-method-in-sysconfig-and-dist.patch.

@jeromerobert
Copy link
Contributor Author

jeromerobert commented Jul 17, 2021

And this commit pybind/pybind11@3ac690b88 also need a fix for mingw.

@jeromerobert jeromerobert mentioned this pull request Jul 18, 2021
Merged
@jeromerobert
Copy link
Contributor Author

jeromerobert commented Jul 18, 2021

It's better to have this in the core repository so the Mingw build is continously tested. PR Moved here: pybind/pybind11#3132

@henryiii henryiii reopened this Aug 4, 2021
@henryiii henryiii merged commit fdc222c into pybind:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeromerobert @henryiii