Use new get_include #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the pybind11 dependency in install_requires as the headers are needed only at setup time.
Contributor
Author
|
@wjakob, @SylvainCorlay, this is ready for review now. |
Contributor
Author
|
This should be merged first as this fixes CI as well. |
Member
|
@isuruf maybe we should remove Python 2 and x86 builds from the appveyor matrix? |
Contributor
Author
|
ping @wjakob. failing tests here are also failing on master. |
Member
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the pybind11 dependency in install_requires
as the headers are needed only at setup time.
Waiting for pybind/pybind11#1995