Use define_macros for macros #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready for review. |
Contributor
Author
|
Ping |
Member
|
Apologies for the long delay. This PR seems to be somewhat garbled relative to 'master' -- could you rebase it? Also, it would be great to have some summary of why you are making those changes? (it wasn't immediately clear to me.) |
wjakob
force-pushed
the
master
branch
2 times, most recently
from
fe696bc to
08a2f37
Compare
Contributor
Author
|
This is ready for review now |
wjakob
added a commit
that referenced
this pull request
Apr 26, 2020
Member
|
This looks good. GitHub wasn't willing to merge this PR due to conflicts, so I just did so directly. |
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
VERSION_INFOtodefine_macrosCopies
stdlibflag to link time as well.