fix(cmake): error wasn't triggering #5676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CMake configuration where the error wasn't triggering correctly due to an incorrect environment variable check.
- Corrects the syntax used to check for the PYBIND11_GLOBAL_PREFIX environment variable
- Ensures proper error messaging when the unsupported variable is defined
Comments suppressed due to low confidence (1)
CMakeLists.txt:68
- The revised environment variable check is correct. Please ensure that this change reliably triggers the intended error and that similar checks in the project use the same syntax.
if(DEFINED SKBUILD AND DEFINED ENV{PYBIND11_GLOBAL_PREFIX})
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryii/ci/fixerror
branch
from
5959be3 to
02ebc76
Compare
Skylion007
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henry Schreiner [email protected]
Description
Bug.
Suggested changelog entry: