Add test for boost::histogram::func_transform situation.
#5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
/__w/pybind11/pybind11/tests/test_callbacks.cpp:33:9: error: 'auto rec' can be declared as 'auto *rec' [readability-qualified-auto,-warnings-as-errors]
33 | auto rec = c.get_pointer<py::detail::function_record>();
| ^~~~
| auto *
/__w/pybind11/pybind11/tests/test_callbacks.cpp:41:13: error: 'auto cap' can be declared as 'auto *cap' [readability-qualified-auto,-warnings-as-errors]
41 | auto cap = reinterpret_cast<capture *>(&rec->data);
| ^~~~
| auto *
```
…std::function<raw_t>>`
rwgk
force-pushed
the
add_test_for_boost_histogram_situation
branch
from
106ef8e to
d2418f0
Compare
rwgk
changed the title
boost::histogram::func_transform situation.func_is_stateless_with_exact_type feature in pybind11/functional.h
Signed-off-by: Henry Schreiner <[email protected]>
rwgk
changed the title
func_is_stateless_with_exact_type feature in pybind11/functional.hboost::histogram::func_transform situation.
```
/__w/pybind11/pybind11/tests/test_callbacks.cpp:33:5: error: 'auto cfunc' can be declared as 'auto *cfunc' [readability-qualified-auto,-warnings-as-errors]
33 | auto cfunc = func.target<raw_t *>();
| ^~~~
| auto *
```
henryiii
reviewed
Mar 27, 2025
tests/test_callbacks.cpp
Outdated
| return -100; | ||
| } | ||
| auto func = static_cast<std::function<raw_t> &>(func_caster); | ||
| auto cfunc = func.target<raw_t *>(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| auto cfunc = func.target<raw_t *>(); | |
| raw_t* cfunc = func.target<raw_t *>(); |
Collaborator
Author
There was a problem hiding this comment.
Oh, I just pusehd the auto * change as suggested by clang-tidy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The added test reflects this change in boost-histogram:
The APIs used in the added test code here are considered public.
See also: Discussions under PR #5580
Suggested changelog entry: